Re: [evolution-patches] #54338:Problem with vFolders of same name.

[Not Zed <notzed ximian com>]

On Thu, 2004-02-19 at 19:16 +0800, Bill Zhu wrote:

> Hi, Not Zed
> 在2004年02月15日的19:07，Not Zed写道：
> > But that does'nt make any sense either, for vfolders the source should
> > be NULL (i think ...), or if not, all the same.  searches will have
> > different sources though.
> > 
> > Why is that bit of code not finding a match, is it passing NULL as
> > source, and the find method isn't dealing with it appropriately, or is
> > it passing a different source when it isn't supposed to?  Or is the
> > problem somewhere completely different (e.g. mail-vfolder.c).
> 
> It is not passing NULL. the sources of vfolders are marked as:       
> "specific", "local", "remote_active" and "local_remote_active".
> As your said, they should be all NULL or all the same, shouldn't they?
> but they looks like specified on purpose, is this a mistake?

Ahh, finally we find the real source of the of the problem (pardon the
pun!).

So I incorrectly and stupidly re-used the filter-rule source attribute
as a short-cut to defining the vFolder source-type as well ... the fewl
me.

Two solutions I guess:
 - make a bunch of rule finding stuff on rule-context virtual, so the
vfolder stuff can make it behave as though source is always NULL
    - no change required to vfolders.xml format
    - kinda messy, a lot of non-obvious functionality going on

 - make the vfolder code store it in a separate attribute instead
    - vfolders.xml format changes slightly
    - will need either upgrade code, or old-version handling of the file
(the later would be the simplest/easiest/most robust).

I'll go for the second one.  Since i've already investigated it, I might
hack it up this morning, shouldn't take too long.

Thanks for finding the base problem here, now a 'more correct' fix can
be done.

 Michael