[evolution-patches] patches for GConf leaks (1.4)



The attached patches fix several leaks on GConf clients, which make both
gconfd-2 and bonobo-activation-server keep running after the session is
closed.
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/e-util/ChangeLog,v
retrieving revision 1.398.2.10
diff -u -p -r1.398.2.10 ChangeLog
--- ChangeLog	10 Jan 2004 08:41:45 -0000	1.398.2.10
+++ ChangeLog	18 Feb 2004 17:55:58 -0000
@@ -1,3 +1,7 @@
+2004-02-18  Rodrigo Moya <rodrigo ximian com>
+
+	* e-proxy.c (e_proxy_init): unref the GConfClient.
+
 2004-01-05  Not Zed  <NotZed Ximian com>
 
 	* e-memory.c (e_mempool_destroy): Fix from Zan Lynx
Index: e-proxy.c
===================================================================
RCS file: /cvs/gnome/evolution/e-util/Attic/e-proxy.c,v
retrieving revision 1.3
diff -u -p -r1.3 e-proxy.c
--- e-proxy.c	16 May 2003 19:20:34 -0000	1.3
+++ e-proxy.c	18 Feb 2004 17:56:01 -0000
@@ -93,4 +93,6 @@ e_proxy_init ()
 				 proxy_setting_changed, NULL, NULL, NULL);
 	
 	set_proxy (client);
+
+	g_object_unref (client);
 }
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/shell/ChangeLog,v
retrieving revision 1.1286.2.10
diff -u -p -r1.1286.2.10 ChangeLog
--- ChangeLog	30 Sep 2003 09:58:01 -0000	1.1286.2.10
+++ ChangeLog	18 Feb 2004 18:02:04 -0000
@@ -1,3 +1,9 @@
+2004-02-18  Rodrigo Moya <rodrigo ximian com>
+
+	* e-config-upgrade.c (e_config-upgrade):
+	* e-shell-offline-sync.c (e_shell_offline_sync_all_folders):
+	* e-shell-view.c (setup_defaults): don't leak GConfClient's.
+
 2003-09-30  Ismael Olea <ismael olea org>
 
 	* e-shell-about-box.c: fixed encoding for Spanish translators.
Index: e-config-upgrade.c
===================================================================
RCS file: /cvs/gnome/evolution/shell/e-config-upgrade.c,v
retrieving revision 1.12.2.1
diff -u -p -r1.12.2.1 e-config-upgrade.c
--- e-config-upgrade.c	12 Sep 2003 07:35:03 -0000	1.12.2.1
+++ e-config-upgrade.c	18 Feb 2004 18:02:07 -0000
@@ -1919,6 +1919,8 @@ e_config_upgrade(const char *edir)
 		gconf_client_suggest_sync(gconf, NULL);
 	}
 
+	g_object_unref (gconf);
+
 	res = 0;
 
 error:
Index: e-shell-offline-sync.c
===================================================================
RCS file: /cvs/gnome/evolution/shell/Attic/e-shell-offline-sync.c,v
retrieving revision 1.10
diff -u -p -r1.10 e-shell-offline-sync.c
--- e-shell-offline-sync.c	25 Mar 2003 15:48:33 -0000	1.10
+++ e-shell-offline-sync.c	18 Feb 2004 18:02:07 -0000
@@ -397,6 +397,7 @@ e_shell_offline_sync_all_folders (EShell
 
 	path_list = gconf_client_get_list (gconf_client, "/apps/evolution/shell/offline/folder_paths",
 					   GCONF_VALUE_STRING, NULL);
+	g_object_unref (gconf_client);
 
 	sync_data = g_new0 (SyncData, 1);
 	sync_data->shell = shell;
Index: e-shell-view.c
===================================================================
RCS file: /cvs/gnome/evolution/shell/Attic/e-shell-view.c,v
retrieving revision 1.285
diff -u -p -r1.285 e-shell-view.c
--- e-shell-view.c	15 May 2003 18:19:16 -0000	1.285
+++ e-shell-view.c	18 Feb 2004 18:02:09 -0000
@@ -455,6 +455,8 @@ setup_defaults (EShellView *shell_view)
 	e_tree_load_expanded_state (E_TREE (priv->storage_set_view),
 				    file_name);
 	g_free (file_name);
+
+	g_object_unref (client);
 }
 
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]