Re: [evolution-patches] (fwd) [patch] 64-bit cleanliness patch

[Rodney Dawes <dobey ximian com>]

On Mon, 2004-02-16 at 23:24, Martin Pool wrote:
> Could you please consider this patch?
> 
> http://bugzilla.ximian.com/show_bug.cgi?id=53164
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=198660
> 
> I don't know if it's still needed in 1.5; I'll test that soon.
> 
> Package: evolution
> Version: 1.4.5-3
> Severity: normal
> Followup-For: Bug #198660
> 
> Here is a patch to make evolution 1.4 work on ia64 (well, at least it
> starts up; that's all I know how to do... ;-).
> 
> The patch fixes the following issues:
> 
>  - configure failed for me because libdb3 has a dependency on -lpthread;
>    fixed by configure.in hacking

> diff -x '*.so*' -x '*.lai' -x Makefile -x .libs -x '*.a' -x '*.o' -x '*.lo' -x '*.la' -x .deps -urN evolution-1.4.5/build-tree/evolution-1.4.5/configure evolution-1.4.5-davidm/build-tree/evolution-1.4.5/configure
> --- evolution-1.4.5/build-tree/evolution-1.4.5/configure	2003-12-21 03:22:57.624972411 -0800
> +++ evolution-1.4.5-davidm/build-tree/evolution-1.4.5/configure	2003-12-20 18:19:34.385074183 -0800
> @@ -23153,7 +23153,7 @@
>  	ac_cv_db3_ldadd=""
>  
>  	for name in db db3 db-3.1; do
> -		LIBS="$LIBS_save $with_db3_libs/lib${name}.a"
> +		LIBS="$LIBS_save $with_db3_libs/lib${name}.a -lpthread"
>  		cat >conftest.$ac_ext <<_ACEOF
>  /* confdefs.h.  */
>  _ACEOF
> @@ -23231,7 +23231,7 @@
>    echo $ECHO_N "(cached) $ECHO_C" >&6
>  else
>  
> -	LIBS="$DB3_LDADD $LIBS"
> +	LIBS="$DB3_LDADD $LIBS -lpthread"
>  	if test "$cross_compiling" = yes; then
>    ac_cv_db3_lib_version_match=yes
>  else
> diff -x '*.so*' -x '*.lai' -x Makefile -x .libs -x '*.a' -x '*.o' -x '*.lo' -x '*.la' -x .deps -urN evolution-1.4.5/build-tree/evolution-1.4.5/configure.in evolution-1.4.5-davidm/build-tree/evolution-1.4.5/configure.in
> --- evolution-1.4.5/build-tree/evolution-1.4.5/configure.in	2003-09-15 11:32:05.000000000 -0700
> +++ evolution-1.4.5-davidm/build-tree/evolution-1.4.5/configure.in	2003-09-15 11:32:05.000000000 -0700
> @@ -358,7 +358,7 @@
>  	ac_cv_db3_ldadd=""
>  
>  	for name in db db3 db-3.1; do
> -		LIBS="$LIBS_save $with_db3_libs/lib${name}.a"
> +		LIBS="$LIBS_save $with_db3_libs/lib${name}.a -lpthread"
>  		AC_TRY_LINK([
>  			#ifdef HAVE_DB3_DB_H
>  			#include <db3/db.h>
> @@ -384,7 +384,7 @@
>  
>  AC_CACHE_CHECK([that db3 library version matches header version], ac_cv_db3_lib_version_match,
>  [
> -	LIBS="$DB3_LDADD $LIBS"
> +	LIBS="$DB3_LDADD $LIBS -lpthread"
>  	AC_TRY_RUN([
>  		#ifdef HAVE_DB3_DB_H
>  		#include <db3/db.h>

This doesn't actually fix the problem. It only slightly works around it.
This also has nothing to do with with building on a 64-bit platform. The
correct solution here would be to fix your db3 build. Why does a static
library depend on a shared library? That behaviour seems inherently
broken to me.

-- dobey