Re: [evolution-patches] calendar, bug #51567,When deleting an appointment in the calendar, the question dialog can't be closed by ESC key

[Rodrigo Moya <rodrigo ximian com>]

On Wed, 2004-02-11 at 14:00 -0500, Bruce Tao wrote:

> Hi all,
> 
> See #51567: When deleting an appointment in the calendar, the question 
> dialog can't
>  be closed by ESC key.
> 
> The patch is for trunk.
> 
> A button with response_id 'GTK_RESPONSE_CANCEL' will make the dialog being
> able to be destroyed by ESC key. So the patch encloses changes the 
> response_ids of both
> the 'Yes' and 'No' buttons on the message_dialog while doesn't affect 
> their funcionality.
> 
> This modification is pretty simple. I'd like to get your review.
> 
it looks ok, except for some formatting:

> +       gtk_dialog_add_buttons((GtkDialog *)dialog,GTK_STOCK_NO,
> GTK_RESPONSE_CANCEL,GTK_STOCK_YES,GTK_RESPONSE_OK,NULL);
>         g_free (str);
> -       ret = gtk_dialog_run ((GtkDialog *)dialog) ==
> GTK_RESPONSE_YES;
> +       ret = gtk_dialog_run ((GtkDialog *)dialog) == GTK_RESPONSE_OK;

please leave a space after the commas and the parenthesis.

Apart from that, it looks ok.

cheers