Re: [evolution-patches] [GtkHTML]Fix i18n problem in gtkhtml-editor component.

[Radek Doulík <rodo ximian com>]

Hi Yong,

the patch looks good. For CVS/HEAD, please replace
GNOME_EXPLICIT_TRANSLATION_DOMAIN with GETTEXT_PACKAGE and commit.

Thanks for the patch
Radek

On Wed, 2004-02-11 at 11:11 +0800, Yong Sun wrote:

> Hi, Radek,
> 
> It's a good point. I reattach my patch according your suggestion. Please
> help to review it.
> 
> Regards,
> 
> 在2004年02月10日的21:57，Radek Doulík写道：
> > Hi Yong,
> > 
> > On Tue, 2004-02-10 at 19:12 +0800, Yong Sun wrote:
> > 
> > > Hi, guys,
> > > 
> > > In gtkhtml-editor component, all the tooltips in toolbar are not
> > > localized. Because gnome_app_fill_toolbar_with_data() function and
> > > struct GnomeUIInfo have no domain information. libgnomeui will gettext
> > > from the main-process's domain (evolution) or libgnomeui's domain, but
> > > not the domain of gtkhtml.
> > > 
> > > Please review this patch. This patch should be applied in 1.4 and trunk.
> > 
> > I don't like accessing the uuinfo fields directly. I think it's cleaner
> > and safer to use textdomain call as we do in menubar_setup.
> > 
> > Cheers
> > Radek
> -- 
> Yong Sun <Yong Sun sun com>
> Sun (China) ERI
-- 
Radek Doulík <rodo ximian com>