[evolution-patches] Re: ctrl-shift-k behavior ...



On Wed, 2004-02-04 at 09:30 +0000, Michael Meeks wrote:
> On Wed, 2004-02-04 at 12:52 +0800, Not Zed wrote:
> > This will mess up enabling of the menu though.
> 
> 	Sure; but it seems to me few people look at that menu - and if c-s-k
> still does something useful even when it's unread it's reasonable to
> have it sensitive.

But it doesn't do anything useful if its read its a noop.  I dont get
how it helps your problem either, since it will still timeout and mark
it read anyway.

> > On Tue, 2004-02-03 at 19:47 +0000, Michael Meeks wrote:
> > > 	For some time I've been annoyed that if you move to a message and hit
> > > ctrl-shift-k before the timeout it still times out, and sets it as read :-)
> > > just had a quick hack, and it turns out this is down to the fact that
> > > 'mark unread' is not sensitive when the mail is un-read - so we never hit
> > > that code path; this tiny patch 'fixes' that; may I commit it ?
> 
> 	May I commit ?

No, because of the above, it should be fixed properly (otherwise we WILL
get another bug report about the menu sensitisation).  Just add a bug
report @ normal level.  Should be able to get to it within a few days.
In the mean time you can keep that patch in your own tree!

This is oone of those bugs which keeps gets fixed and seems to break
again when some seemingly unrelated bug gets fixed.

 Michael





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]