[evolution-patches] [PATCH] Use widget instead of control for New button

[Anders Carlsson <andersca gnome org>]

Hello,

attached is a patch that uses a widget directly for the New button in
the evolution shell. This avoids an unnecessary plug/socket pair and
makes the button look better when using such themes as Crux.

Anders

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/shell/ChangeLog,v
retrieving revision 1.1385
diff -u -p -r1.1385 ChangeLog
--- ChangeLog	29 Jan 2004 14:36:38 -0000	1.1385
+++ ChangeLog	2 Feb 2004 20:07:38 -0000
@@ -1,3 +1,9 @@
+2004-02-02  Anders Carlsson  <andersca gnome org>
+
+	* e-user-creatable-items-handler.c: (setup_toolbar_button):
+	Use bonobo_ui_component_widget_set to avoid creating an unnecessary
+	plug/socket pair for in-proc components.
+	
 2004-01-29  JP Rosevear <jpr ximian com>
 
 	* main.c: turn development stuff back on
Index: e-user-creatable-items-handler.c
===================================================================
RCS file: /cvs/gnome/evolution/shell/e-user-creatable-items-handler.c,v
retrieving revision 1.5
diff -u -p -r1.5 e-user-creatable-items-handler.c
--- e-user-creatable-items-handler.c	14 Dec 2003 15:54:39 -0000	1.5
+++ e-user-creatable-items-handler.c	2 Feb 2004 20:07:38 -0000
@@ -590,7 +590,6 @@ setup_toolbar_button (EUserCreatableItem
 	GtkWidget *combo_button;
 	GtkWidget *menu;
 	GtkTooltips *tooltips;
-	BonoboControl *control;
 
 	priv = handler->priv;
 
@@ -606,13 +605,9 @@ setup_toolbar_button (EUserCreatableItem
 	ui_component = e_shell_window_peek_bonobo_ui_component (window);
 	bonobo_window_add_popup (BONOBO_WINDOW (window), GTK_MENU (menu), "/popups/NewPopup");
 
-	control = bonobo_control_new (combo_button);
+	bonobo_ui_component_widget_set (ui_component, "/Toolbar/NewComboButton",
+					combo_button, NULL);
 
-	bonobo_ui_component_object_set (ui_component, "/Toolbar/NewComboButton",
-					BONOBO_OBJREF (control), NULL);
-
-	bonobo_object_unref (control);
-	
 	g_object_set_data (G_OBJECT (window), COMBO_BUTTON_WIDGET_KEY, combo_button);
 
 	tooltips = gtk_tooltips_new ();