Re: [evolution-patches] patch for #68454 (address book)
- From: Sivaiah <snallagatla novell com>
- To: Hans Petter Jansson <hpj ximian com>
- Cc: evolution-patches <evolution-patches lists ximian com>
- Subject: Re: [evolution-patches] patch for #68454 (address book)
- Date: Mon, 20 Dec 2004 03:56:26 -0800
Committed to HEAD and gnome-2-8 branch after fixing formatting
Siva
On Sun, 2004-12-19 at 12:22 -0600, Hans Petter Jansson wrote:
> On Sun, 2004-12-19 at 06:08 -0800, Sivaiah Nallagatla wrote:
> > Attached path adds objectclass=person to ldap filter so that we get only
> > objects belonging to person and classes derived from it (like,
> > InetOrgPerson, evolutionPerson). We do not want to display Org,
> > Orginzation Unit and other objects as contacts in evo.
>
> Looks ok. The code formatting is slightly inconsistent - e.g. you put a
> space after the function in a function call some places, but not others,
> and there is an extra blank line at the end of the scope. Maybe you can
> correct that before you commit.
>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]