[evolution-patches] Re: patch about gtkhtml, fix #70078



hi rodo,

Thanks very much for your review.
I had changed the prev_object variable to gtk_html_a11y_focus_object
global variable. 
and harry had help me check in.

yours
Mengjie Yu

On Tue, 2004-12-14 at 10:02, Radek Doulik wrote:
> Hi Mengjie,
> 
> thanks a lot for your patch. It looks mostly OK. Only thing I noticed
> this time is prev_object variable changing scope. It becomes global
> variable so please prefix it with gtk_html_a11y_ and maybe even rename
> it to gtk_html_a11y_focus_object? Once this is fixed the patch is OK
> to commit.
> 
> Cheer
> Radek
> 
> On Tue, 2004-12-14 at 18:26 -0800, Mengjie Yu wrote: 
> > hi, rodo
> > 
> > I resend my patches. One mail only contains one patch against one bug.
> > 
> > Please ignore all patches I send you before.
> > 
> > Thanks for your review.
> > 
> > Your,
> > Mengjie Yu




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]