Re: [evolution-patches] Patch for some UI issues(revised)

[Rodney Dawes <dobey novell com>]

The problem with the mail part is that the dialog just needs to be
redesigned a bit more than adding another box for a single label.

As for your re-submitted patch:

You should specify the modified function name in the calendar ChangeLog
also.

There are still a couple whitespace changes in the calendar that don't
need to happen. Such as:

@@ -371,7 +371,6 @@ calendar_setup_edit_calendar (struct _Gt
        } else {
                GConfClient *gconf;
                GSList *l;
-
                sdialog->source = e_source_new ("", "");
                gconf = gconf_client_get_default ();
                sdialog->source_list = e_source_list_new_for_gconf
(gconf, "/apps/evolution/calendar/sources");

This change should be removed from the patch before it gets committed.

The address book changes look fine now though.

-- dobey

On Fri, 2004-12-10 at 11:23 +0530, Vivek Jain wrote:
> I am resending the patch, for the ui issues, removing mail part and
> including suggested changes in the address-book and calendar. However, I
> am still not very much clear about the problem in the mail part.
> 
> Vivek