Re: [evolution-patches] Patch to fix bug #61610, display a message count on draft folders.



a couple things...

- I'm not sure this is desirable behaviour? We'll need someone from the
UI design team to review this change and give us their opinions on
whether or not this should be done...

- your patch will only work for local folders but Drafts folders can be
changed to point to any folder, not just the local drafts folder (e.g.
the user might have a drafts folder on his/her imap server).

- indenting seems wrong?

-                       if (folder == mail_component_get_folder(NULL, MAIL_COMPONENT_FOLDER_OUTBOX)) {
+                       if (folder == mail_component_get_folder(NULL, MAIL_COMPONENT_FOLDER_OUTBOX) 
+                                       || folder == mail_component_get_folder(NULL, MAIL_COMPONENT_FOLDER_DRAFTS)) {

- also, get rid of the extra blank line you accidently added:

                camel_object_unref(folder);
+
        }

Jeff

On Tue, 2004-12-07 at 10:12 +0100, Félix Ortega wrote:
> Here is the patch. Is the first patch I submit, so if I made something
> wrong please tell so.
> 
-- 
Jeffrey Stedfast
Evolution Hacker - Novell, Inc.
fejj ximian com  - www.novell.com

Attachment: smime.p7s
Description: S/MIME cryptographic signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]