Re: [evolution-patches] patch for #67403 (calendar) for 2.0.x



looks fine to me..

--harish

On Mon, 2004-12-06 at 16:20 +0100, Rodrigo Moya wrote:
> On Mon, 2004-12-06 at 19:27 -0800, Harish Krishnaswamy wrote:
> > On Wed, 2004-12-01 at 13:21 +0100, Rodrigo Moya wrote:
> > 
> > >  gboolean have_selected, read_only;
> > > +
> > > +       if (!e_cal_is_read_only (dialog->ecal, &read_only, NULL))
> > > +               read_only = TRUE;
> > 
> > 
> > In the above line, we need to explicitly check for the error returned by
> > e_cal_is_read_only. - This is because a BUSY error , common with
> > groupwise and exchange back-ends, would cause the client to set the
> > calendar as read_only.
> > 
> > the rest looks fine.
> > 
> ok, updated patch with your comments




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]