Re: [evolution-patches] GNOME Bounty feturerequest #127557

[Philip Van Hoof <spamfrommailing freax org>]

On Wed, 2004-12-01 at 17:53 +0100, Rodrigo Moya wrote:
> On Fri, 2004-11-19 at 14:57 +0100, Philip Van Hoof wrote:
> > More information:
> > 
> > http://bugzilla.gnome.org/show_bug.cgi?id=127557
> > http://www.gnome.org/bounties/Tasks.html#127557
> > 
> some comments below:

Okay

> > +static gchar *
> > +icaltimetype_to_gchar (icaltimetype *t)
> > +{
> > +       if (t) return g_strdup_printf (_("%2d/%2d/%4d %2d:%2d:%2d"),
> > t->month, t->day, t->year, t->hour, t->minute, t->second);
> > +       else return g_strdup ("");
> > +}
> please use evolution coding standards, so,
> 	if (t)
> 		...
> 	else
> 		return ...


Yes. I just recently read the coding guidelines on the developer pages
of Evolution. Next patch I'll try to make sure I follow them.


> > +       /* ask the user for destination file */
> > +#ifdef USE_GTKFILECHOOSER
> > +       dialog = gtk_file_chooser_dialog_new (_("Select destination
> > file"),
> > +                                             NULL,
> > +
> > GTK_FILE_CHOOSER_ACTION_SAVE,
> > +                                             GTK_STOCK_CANCEL,
> > GTK_RESPONSE_CANCEL,
> > +                                             GTK_STOCK_SAVE,
> > GTK_RESPONSE_OK,

>                                              NULL);
> I guess we should probably put this code in one function and call that
> function from do_save_calendar*

'ask_destination_and_save' In the newer versions of the patch is doing
something like that.

> could you also make do_save_calendar use gnome_vfs_* instead of using an
> ECal?

To let the 'do_save_calendar_ical' (which is what's used in newer
versions of the patch) use gnome-vfs, I fear some ecal plugins will need
to be modified. I haven't yet looked at the internals of this API. At
this moment it's also writing the ical-file to a directory with only one
file in it. 


> this is needed when you change some fields, like the start date. Why did
> you add it here?

No reason. The documentation explains that for some operations it's
needed (to make sure things are synced). I guess it can be removed
(which I will next patch).

Note. The 'Save-calendar plugin. saving to comma separated files'
subject in Evolution-Patches is a followup on these E-mails.

http://bugzilla.gnome.org/attachment.cgi?id=34319&action=view is
currently the last version of these series of patches.


-- 
Philip Van Hoof, Software Developer @ Cronos
home: me at freax dot org
gnome: pvanhoof at gnome dot org
work: philip dot vanhoof at cronos dot be
junk: philip dot vanhoof at gmail dot com
http://www.freax.be, http://www.freax.eu.org