Re: [evolution-patches] Patch for bug #127541 - Default Free Busy URI

[JP Rosevear <jpr novell com>]

On Sat, 2004-11-27 at 19:21 -0400, James Bowes wrote:
> On Fri, 2004-26-11 at 18:37 -0400, James Bowes wrote:
> > On Wed, 2004-24-11 at 13:34 -0500, JP Rosevear wrote:
> > > For the actual operation, perhaps you should add a notification in
> > > calendar-config.[hc] that is listened to in e-meeting-store (or some
> > > "controller") and issues a refresh call to rebuild the data.
> > > 
> > 
> > I set up e-meeting-time-sel to watch for changes to to the gconf
> > setting, since it has the start and end times that are needed for
> > rebuilding the data.
> > 
> 
> I've attached a new version of the patch. This one listens for focus-out
> events on the gtk-entry used to set the template uri in the prefs
> window. This way, the setting is only saved once, rather than after
> every key press, which also reduces the number gnome-vfs reads while
> refreshing the meeting-store.

Ok, a few more comments.  You are using %d and %u now but the schema
default has not changed.  In fact, I'm not sure there should be a
default, because if someone never sets it they will get a lot of useless
lookups and anger admins whose servers are being pinged.  The focus
stuff does cut down on f/b lookups when a meeting is open and the url is
changing but doesn't really mesh with how the other settings are set.
Perhaps calendar-config or e-meeting-time-sel could wait 5 seconds or
something before starting a refresh when the url changes? And reset to 5
seconds if it changes in the 5 second interval.

I'll let harish comment on the async loading stuff since that's his
code.

Looking pretty sweet right now.

-JP
-- 
JP Rosevear <jpr novell com>
Novell, Inc.