Re: [evolution-patches] fix for the bug #64062 [calendar]

[Rodrigo Moya <rodrigo novell com>]

On Sun, 2004-08-29 at 20:51 +0530, chenthill wrote:
> Hi,
>    Added the support for the allday events in groupwise appointments.
> 

> +                       if (s_dt.tzid && !cache_s_dt.tzid) {
> +                               is_allday = FALSE;
> +                               
> +                               e_gw_item_set_is_allday_event (item,
> is_allday);
> +                               e_gw_item_set_change (item,
> E_GW_ITEM_CHANGE_TYPE_UPDATE, "allDayEvent", &is_allday);
> +                       } else if (!s_dt.tzid && cache_s_dt.tzid) {
> +                               is_allday = TRUE;
> +                               
> +                               e_gw_item_set_is_allday_event (item,
> is_allday);
> +                               e_gw_item_set_change (item,
> E_GW_ITEM_CHANGE_TYPE_UPDATE, "allDayEvent", &is_allday);
> +                       }
that could be reduced somehow, by having:

	if (...)
		is_allday = FALSE;
	else
		is_allday = TRUE;
	e_gw_item_set_is_allday_event (item, is_allday);
	e_gw_item_set_change ...

> -       rdate = isodate_from_time_t (instance_start);
> +       rdate = isodate_from_time_t (instance_end);
> 
why do you use the instance_end? The recurrence dates are always the
instance_start.

> +                       if (is_allday) {
> +                               char **temp = g_strsplit (t, "T", -1);
> +                               
> +                               if (temp [0])
> +                                       t = g_strdup (temp [0]);
> +                               g_strfreev (temp);
> +                       }
what's the need for this? You can just get itt_utc from the 't' time
string, and then set the is_allday field to TRUE/FALSE in the struct
icaltimetype type.
-- 
Rodrigo Moya <rodrigo novell com>