Re: [evolution-patches] patch for #62593 (camel groupwise provider)

[Harish Krishnaswamy <kharish novell com>]

hi,

Guess
>
>if (!is_personalbooks_present) {

should be executed within the 
>
>if (status == E_GW_CONNECTION_STATUS_OK) {

block since we do want to attempt to create the personal address books 
if the connection status was not OK in the first place.

harish

On Mon, 2004-08-30 at 11:28 +0800, Not Zed wrote:
> 
> Only real thing - i guess the name "Freqeunt Contacts" doesn't have to
> be translated?
> 
> Also with the g_free(id) thing, just do
> g_free(id);
> id = NULL;
> rather than
> if (id) {
>     ...
> }
> 
> since g_free already checks for a null pointer and it just makes the
> code neater.
> 
> also some of the whitespace is messy, put one blank line after if ()
> {} blocks only if followed by more code, not another }.
> 
> On Fri, 2004-08-27 at 21:27 +0530, Sivaiah N wrote: 
> > Hi,
> > Attahed patch creates two personl addr books for a groupwise user,
> > during account setup   if he  does not have them already to be
> > inconsistent with win32 client behaviour 
> > 
> > Thanks,
> > Siva