Re: [evolution-patches] gal/e-text patch for 63731

[Not Zed <notzed ximian com>]

Ok this patch will do.

I don't know who now needs to be asked for approval on the 2.8 branch - it seems to change every week.

It can be committed to head now though, but it should also go into the branch once that's approved.


On Fri, 2004-08-27 at 14:43 +0800, Not Zed wrote:

I don't really like this much, but it may do, other solutions might get complex.

Can you just keep track of the last canvas item which was given focus, and apply any events to that only?  Or do you keep getting events even when some other totally unrelated widget gets focus (in which case this patch wont work either).

Or can it just have a global imcontext for the widget, and always listen to it, but just apply its input to the currently active object.

But as i said to start with, if it works it may do.

On Thu, 2004-08-26 at 18:56 -0700, Suresh Chandrsekharan wrote:

Hi Michael,
    I have created another patch.
http://bugzilla.ximian.com/showattachment.cgi?attach_id=9697
Have put some explanation for the use of static variable inside e_text_event.

Thanks,
Suresh

On 水, 2004-08-25 at 21:29, Not Zed wrote:

Ouch, that sounds fun.  Yes just please commit a reverse patch for now.

On Wed, 2004-08-25 at 21:16 -0700, Suresh Chandrasekharan wrote:

Hi Michael,
	Seems like the patch that I committed to gal head causes a problem. In 
calender adding some words to one appointment's summary, other appointment's 
summary will change.
	This is due to the text->im_context shared by all EText children of the 
GnomeCanvas, so unless you explicitly connect/disconnect the signal for each 
EText child commit callbacks will be emitted for all EText childern of 
GnomCanvas and it will cause multiple update issue.
	I'm planning to rollback my changes and will try to comeup with a 
simpler solution to the original issue. Sorry for this oversight from my part.
	

Regards,
Suresh
	

--

Michael Zucchi <notzed ximian com> "born to die, live to work, it's all downhill from here" Novell's Evolution and Free Software Developer

--

Michael Zucchi <notzed ximian com> "born to die, live to work, it's all downhill from here" Novell's Evolution and Free Software Developer