Re: [evolution-patches] warning removal patch for libecal



On Thu, 2004-08-26 at 12:34 -0400, JP Rosevear wrote:
> On Wed, 2004-08-25 at 14:19 +0200, Rodrigo Moya wrote:
> 
> Wow, this looks like it would have accessed memory improperly and been
> potentially very bad.
>
yes, seems so

>   Approved.
>
committed

>  Could this have been the cause of that
> other bug with the null instance in the hash table?
> 
not sure, since the crash was when opening the calendar, and AFAIR, we
don't construct instances there.

> Why are we expanding the recurrences with the libical bits here though?
> 
hmm, right, we probably just want to use the e_cal_recur code. I'll
change it and send a separated patch.
-- 
Rodrigo Moya <rodrigo novell com>




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]