Re: [evolution-patches] gal/e-text patch for 63731

[Suresh Chandrsekharan <suresh chandrasekharan sun com>]

Thanks for the feedback. You're right,  code looks cleaner this way. Pl review the new patch.
http://bugzilla.ximian.com/showattachment.cgi?attach_id=9475

2004/08/23 (月) 20:23 に Not Zed さんは書きました:

I wonder given this change if the code shouldn't just connect to the signals whenever it sets up the imcontext?

I also notice that the set_property method doesn't un-hook from any events from the old im_context if it is re-set, which would be a bug.

Maybe set_property should just hook and unhook the signals itself, so the signal handlers are always setup, since this change will effectively do the same thing at a different time.


On Mon, 2004-08-23 at 20:27 -0700, Suresh Chandrsekharan wrote:

See the patch for
http://bugzilla.ximian.com/show_bug.cgi?id=63731
at
http://bugzilla.ximian.com/showattachment.cgi?attach_id=9360

Thanks,
Suresh

--

Michael Zucchi <notzed ximian com> "born to die, live to work, it's all downhill from here" Novell's Evolution and Free Software Developer