Re: [evolution-patches] patch for bug #62065 [calendar]

[chenthill <pchenthill novell com>]

Have modified the patch to free the string returned by
soup_soap_parameter_get_property.

thanks,
chenthill.

On Thu, 2004-08-19 at 11:48 +0530, Sivaiah N wrote:
> the string returned by soup_soap_parameter_get_property should be freed
> 
> Thanks,
> Siva
> On Thu, 2004-08-19 at 11:06 +0530, chenthill wrote:
> > Hi,
> >    The calendar items were not being displayed due to a crash in E-D-S,
> > while trying to access the element "message" from the soap message when
> > it is NULL. Have attached a patch which solves this.
> > 
> > thanks,
> > chenthill. 
> 
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches

? 60625.diff
? 62065.diff
? patch
? groupwise/.e-gw-item.c.swo
? groupwise/doc/.gw-soap-methods.xsd.swp
? groupwise/doc/.gw-soap-types.xsd.swp
Index: groupwise/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution-data-server/servers/groupwise/ChangeLog,v
retrieving revision 1.60
diff -u -r1.60 ChangeLog
--- groupwise/ChangeLog	13 Aug 2004 15:35:16 -0000	1.60
+++ groupwise/ChangeLog	19 Aug 2004 09:04:00 -0000
@@ -1,3 +1,10 @@
+2004-08-18  Chenthill Palanisamy <pchenthill novell com>
+	
+	Fixes #62065
+	* e-gw-tem.c
+	(e_gw_item_new_from_soap_parameter): Check whether message
+	element has content in it before trying to decode it.
+
 2004-08-13  Chenthill Palanisamy <pchenthill novell com>
 
 	* e-gw-item.h
Index: groupwise/e-gw-item.c
===================================================================
RCS file: /cvs/gnome/evolution-data-server/servers/groupwise/e-gw-item.c,v
retrieving revision 1.44
diff -u -r1.44 e-gw-item.c
--- groupwise/e-gw-item.c	13 Aug 2004 15:35:16 -0000	1.44
+++ groupwise/e-gw-item.c	19 Aug 2004 09:04:01 -0000
@@ -1432,11 +1432,19 @@
 			SoupSoapParameter *part;
 			int len;
 			char *msg;
+			char *length;
 			
 			part = soup_soap_parameter_get_first_child_by_name (child, "part");
 			msg = soup_soap_parameter_get_string_value (part);
-			len = atoi (soup_soap_parameter_get_property (part, "length"));
-			item->priv->message = soup_base64_decode  (msg, &len);
+			length = soup_soap_parameter_get_property (part, "length"); 
+
+			if (msg && length) {
+				len = atoi (length);
+				item->priv->message = soup_base64_decode  (msg, &len);
+			}
+
+			g_free (length);
+			g_free (msg);
 		}
 
 		else if (!g_ascii_strcasecmp (name, "place"))