Re: [evolution-patches] Ask user to make evolution default mail app bug #127526 (Mail)

[Not Zed <notzed ximian com>]

BTW the patch also requires ChangeLog entries, and an entry for the evolution-mail.schemas.in.in file for the gconf schema.  See the 'prompt settings' section in the schema.

Those and the other minor changes before should be enough.

Oh, and by convention i'm trying to use 'ask-xxx-xxx' as the error id for question dialogues.

On Tue, 2004-08-17 at 15:46 +0300, Niklas Nylund wrote:
> I forgot to CC you when I posted this on evolution-patches, because of 
> that I'm sending this mail again. I had also accidentaly left some 
> unnecessary stuff in the patch I posted to the maillinglist, it's 
> removed in this one.
>
> > You should probably use em_utils_prompt_user for the actual asking.  
> > Assuming it will do the key thing right (although it behaves a bit 
> > strangely).  If it doesn't you should do something similar, using 
> > e_error to build the dialogue, rather than gtk_dialog directly.  It 
> > should save you work, and make them visually consistent.
>
> Okay, i rewrote the code to use em_utils_prompt_user, I ended upp adding
> a new error in mail-errors.xml.
>
> Feel free to rename the function and the error id.
>
> Niklas
>
>
> >>When Evolution is launched I first check the "prompt key" and if needed
> >>the default mail app key. I don't know how useful this is if say the 
> >>user first selects Evolution as his/hers default app. and checks "Don't 
> >>ask this again". Later another application changes the default mail app. 
> >>key, then Evolution will not notify the user the next time it's started 
> >>(Since the prompt flag is still false). Should I add something which 
> >>fixes this to Tools->Settings or is this to be taken care of by 
> >>gconf-editor or some similar Gnome application?
> >>
> >>One annoying thing exists though, the first time the user launches 
> >>Evolution both the wizard and the default mail app. dialog box appears, 
> >>since I added my function check_default_mail_app() to the end of 
> >>mail_component_init. But surely anyone with more experience from the 
> >>code knows a better place to put the check.
> >>
> > 
> > It should probably go in the shell somewhere in this version of 
> > evolution.  Although this will have to target 2.2 anyway, since 2.0 is 
> > frozen; we might not have the wizard anymore in 2.2.  So uh, i guess 
> > leave it in the mailer for now.
> > 
> > There's some minor formatting consistencies, and 
> > i'm_no_fan_of_sentences_for_function_names if they can be avoided.
> > 
> > -- 
> > 	*Michael Zucchi* <notzed ximian com <mailto:notzed ximian com>>
> > /"born to die, live to work, it's all downhill from here"/
> > Novell's Evolution <http://codeblogs.ximian.com/blogs/evolution/> and 
> > Free Software <http://www.gnu.org/philosophy/free-sw.html> Developer
> > 
> >

--

Michael Zucchi <notzed ximian com> "born to die, live to work, it's all downhill from here" Novell's Evolution and Free Software Developer