Re: [evolution-patches] patch for #62700

[Not Zed <notzed ximian com>]

note that it breaks string freeze, so i think jp needs to approve too.

FWIW I prefer GNU style for multi-line expressions, makes them more readable since english reads left ot right.

e.g.

+               if ((old_poa_address && strcmp (old_poa_address, new_poa_address)) ||
+                   (old_soap_port && strcmp (old_soap_port, new_soap_port)) ||
+                   strcmp (old_url->user, new_url->user) ||
+                   ((old_use_ssl || new_use_ssl ) && (!old_use_ssl || !new_use_ssl))) {
                        
if ((old_poa_address && strcmp(old, new))
    || (old_port && strcmp(old, new))
    || ...etc

The last check looks complex.  You just want to know if its different right?  Its easier just to check old_use_ssl != new_use_ssl, or use exclusive or.  (old_use_ssl ^ new_use_ssl), which will result the same anyway.  Or since its a string: either compare it, or convert it to a boolean first.

i.e.  (old_use_ssl == NULL) != (new_use_ssl == NULL)


On Tue, 2004-08-17 at 19:23 +0530, Sivaiah N wrote:
> Hi,
> Currently during groupwise account setup if the setting specified are
> incorrect we throw up dialog asking user to delete and recreate the
> account. Also when an account is edited we don't check whether we can
> connect with new settings.
>
> Attached patch solves both the problems by tying to connect to server
> whenever the setting required for soap interaction changes and re
> setting up the e-sources. 
>
> The error message we give now changes as we now just ask user to check
> his settings 
>
> Thanks,
> Siva

--

Michael Zucchi <notzed ximian com> "born to die, live to work, it's all downhill from here" Novell's Evolution and Free Software Developer