Re: [evolution-patches] Wrong Undo operation of input method handling on editor

[Yukihiro Nakai <ynakai redhat com>]

Updated in:
http://bugzilla.ximian.com/show_bug.cgi?id=62637

Thanks for your review.
--
Nakai

On Wed, 11 Aug 2004 14:47:09 +0200

> Hi,
> 
> your patch looks mostly good. Just few comments:
> 
> I would like to have undo freeze/thaw implemented using integer counter
> rather than using simple boolean flag.
> 
> Also please use the same indentation style as gtkhtml sources (eg. if
> (undo->freeze_count <= 0) instead of if( undo->freeze ) and
> html_undo_freeze (html->engine->undo); instead of html_undo_freeze(html-
> >engine->undo);).
> 
> Please put the freeze test always to the top of undo methods (not as in
> html_undo_discard_redo).
> 
> Cheers
> Radek
> 
> On Sat, 2004-08-07 at 01:27 +0900, Yukihiro Nakai wrote:
> 
> > Hi,
> > 
> > Many nice i18n works on evolution happen in this list,
> > but I don't think anybody even thinks about this undo failure.
> > 
> > Users compose mails so frequently, so the behavior on
> > editor changes usability so much.
> > 
> > http://bugzilla.ximian.com/show_bug.cgi?id=62637
> > 
> > Thanks.
> 
> -- 
> Novell, Inc.
> 


--