new patch On Fri, 2004-08-13 at 11:34 +0800, Not Zed wrote: > On Thu, 2004-08-12 at 13:53 -0400, Jeffrey Stedfast wrote: > > On Fri, 2004-08-13 at 00:27 +0800, Not Zed wrote: > > > > > > dont bother with a search_response, just destroy it and set the search > > > dialog to null. > > > > I was wondering if I should have done this... > > > > > > > > infact, shouldn't it just be doing gtk_window_set_transient_for and > > > gtk_window_set_destroy_with_parent, when it's created? > > > > this was my first thought, but is there any way to get the parent > > window? > > the html is a widget is a window, if it requires a toplevel, you can > just get that too, it will always have one at this point. > -- Jeffrey Stedfast Evolution Hacker - Novell, Inc. fejj ximian com - www.novell.com
? 55303-2.patch ? 55303.patch ? 62377.patch ? 62771-mailer.patch ? 62812.patch ? camel-gpg.0.verify.data ? camel-gpg.0.verify.signature ? camel-gpg.1.verify.data ? camel-gpg.1.verify.signature ? camel-gpg.2.verify.data ? camel-gpg.2.verify.signature Index: ChangeLog =================================================================== RCS file: /cvs/gnome/evolution/mail/ChangeLog,v retrieving revision 1.3433 diff -u -r1.3433 ChangeLog --- ChangeLog 12 Aug 2004 20:40:11 -0000 1.3433 +++ ChangeLog 13 Aug 2004 17:49:08 -0000 @@ -1,3 +1,11 @@ +2004-08-13 Jeffrey Stedfast <fejj novell com> + + Fix for bug #62812 + + * em-format-html-display.c (em_format_html_display_search): Set + the search_dialog to be transient for the parent window and make + sure to destroy the search_dialog when the parent gets destroyed. + 2004-08-12 Carlos Garnacho Parro <carlosg gnome org> * em-utils.c: Optionally use GtkFileChooser if compiled against Index: em-format-html-display.c =================================================================== RCS file: /cvs/gnome/evolution/mail/em-format-html-display.c,v retrieving revision 1.49 diff -u -r1.49 em-format-html-display.c --- em-format-html-display.c 6 Aug 2004 17:36:01 -0000 1.49 +++ em-format-html-display.c 13 Aug 2004 17:49:08 -0000 @@ -242,7 +242,7 @@ html_engine_set_tokenizer(efh->html->engine, (HTMLTokenizer *)efhd->search_tok); g_signal_connect(efh->html, "realize", G_CALLBACK(efhd_gtkhtml_realise), o); - + /* we want to convert url's etc */ efh->text_html_flags |= CAMEL_MIME_FILTER_TOHTML_CONVERT_URLS | CAMEL_MIME_FILTER_TOHTML_CONVERT_ADDRESSES; #undef efh @@ -517,6 +517,8 @@ p->search_wrap = FALSE; gtk_dialog_set_default_response((GtkDialog *)p->search_dialog, GTK_RESPONSE_ACCEPT); + e_dialog_set_transient_for ((GtkWindow *) p->search_dialog, (GtkWidget *) ((EMFormatHTML *) efhd)->html); + gtk_window_set_destroy_with_parent ((GtkWindow *) p->search_dialog, TRUE); efhd_update_matches(efhd); g_signal_connect(p->search_entry, "activate", G_CALLBACK(efhd_search_entry_activate), efhd);
Attachment:
smime.p7s
Description: S/MIME cryptographic signature