Re: [evolution-patches] EVO_LDAP_CHECK patches again
- From: Dan Winship <danw novell com>
- To: Rodney Dawes <dobey novell com>
- Cc: evolution-patches lists ximian com
- Subject: Re: [evolution-patches] EVO_LDAP_CHECK patches again
- Date: Fri, 13 Aug 2004 10:50:06 -0400
> - AC_ARG_WITH(openldap, [ --with-openldap=[no/yes/PREFIX] Enable LDAP support in evolution])
> + AC_ARG_ENABLE(openldap, [ --enable-openldap=[no/yes/PREFIX] Enable LDAP support in evolution], with_openldap_prefix="$withval", with_openldap_prefix="/usr")
This shouldn't be changed. The autoconf docs say to use --with-foo for
an optional package, and --enable-foo for an optional feature.
(If you insist on changing it anyway, you need to change $withval to
$enableval.)
> AC_CACHE_CHECK([for OpenLDAP], ac_cv_with_openldap, ac_cv_with_openldap="${with_openldap:=$default}")
This should go away. (It's not really doing much any more anyway.)
AC_CACHE_CHECK can only remember one value, and we need three now.
($with_openldap, $with_openldap_includes, $with_openldap_libs)
Also, the idea was that evo, e-d-s, and evolution-exchange should have
identical acinclude.m4's. It looks like you copied a bugfix from e-d-s
to evo-exchange, so that's good. If there are any other differences,
they should be merged too.
-- Dan
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]