Re: [evolution-patches] Patch: kerberos library location patch

[Rodney Dawes <dobey novell com>]

Looks ok. :)

On Thu, 2004-08-12 at 18:16 +0200, Frederic Crozat wrote:
> Le jeu 12/08/2004 �7:21, Rodney Dawes a �it :
> > On Thu, 2004-08-12 at 10:18 +0200, Frederic Crozat wrote:
> > > Le mer 11/08/2004 �9:51, Rodney Dawes a �it :
> > > > This also needs to be done for the evolution-exchange module.
> > > 
> > > Never happy :))
> > > 
> > > PS : please, reply below quoted text..
> > 
> > 
> > > +AC_ARG_WITH(krb5, [  --with-krb5=PREFIX      Location of Kerberos 5
> > > install dir], with_krb5="$withval", with_krb5="/usr")
> > 
> > This should probably say "Location of Kerberos 5 installation"
> > 
> > > +AC_ARG_WITH(krb5_libs, [  --with-krb5-libs=LIBDIR Location of
> > > Kerberos 5 libs], with_krb5_libs="$withval",
> > > with_krb5_libs="$with_krb5/lib")
> > 
> > Shouldn't this be "krb5-libs" as the first argument to AC_ARG_WITH?
> > Also, it should say "Location of Kerberos 5 libraries" instead of "libs"
> > I think.
> > 
> > We probably should have a --with-krb5-includes as well, to be complete.
> > Another thing to mention is that the help summary should probably use
> > =DIR, instead of =PREFIX and =LIBDIR, and such.
> > 
> > Other than that, it seems functionally fine though.
> 
> Since I already committed the first version, here is a patch for your
> comments. 
>