Re: [evolution-patches] patch for #62113 (calendar)

[Rodrigo Moya <rodrigo novell com>]

On Wed, 2004-08-11 at 00:59 -0400, JP Rosevear wrote:
> On Tue, 2004-08-10 at 17:22 +0200, Rodrigo Moya wrote:
> > On Tue, 2004-08-10 at 17:08 +0200, Rodrigo Moya wrote:
> > > This deals correctly with updates to instances of recurring meetings
> > >
> > sorry, updated correct patch attached, discard the previous one
> 
> Hmm, its seems that now in e-itip-control we send a cancellation for the
> instance - in 1.4 I think we just sent a new REQUEST with the EXDATE
> updated.  It appears as though the file backend will handle this, but we
> need to confirm the groupwise and exchange backends will as well (the
> exchange backend used to special case this i believe).
> 
as we talked in the meeting, it's probably better to use receive_objects
instead of modify_object. In fact, we are using receive_objects in some
other place in that same file (update_item). So, here's an updated patch
-- 
Rodrigo Moya <rodrigo novell com>

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
retrieving revision 1.2484
diff -u -p -r1.2484 ChangeLog
--- ChangeLog	12 Aug 2004 06:55:23 -0000	1.2484
+++ ChangeLog	12 Aug 2004 15:57:43 -0000
@@ -1,3 +1,11 @@
+2004-08-10  Rodrigo Moya <rodrigo novell com>
+
+	Fixes #62113
+
+	* gui/e-itip-control.c (update_attendee_status): use receive_objects
+	method on the backend rather than modify_object, since backends should
+	be dealing correctly with updates to individual instances.
+
 2004-08-10  Not Zed  <NotZed Ximian com>
 
 	* gui/e-pub-utils.c (e_pub_publish): 
Index: gui/e-itip-control.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/e-itip-control.c,v
retrieving revision 1.158
diff -u -p -r1.158 e-itip-control.c
--- gui/e-itip-control.c	9 Aug 2004 12:57:15 -0000	1.158
+++ gui/e-itip-control.c	12 Aug 2004 15:57:45 -0000
@@ -46,6 +46,7 @@
 #include <libecal/e-cal-component.h>
 #include <libecal/e-cal-time-util.h>
 #include <libecal/e-cal.h>
+#include <libecal/e-cal-util.h>
 #include <e-util/e-time-utils.h>
 #include <e-util/e-dialog-widgets.h>
 #include <e-util/e-html-utils.h>
@@ -1889,7 +1890,7 @@ update_attendee_status (EItipControl *it
 			}
 		}
 
-		if (!e_cal_modify_object (priv->current_ecal, icalcomp, CALOBJ_MOD_ALL, &error)) {
+		if (!e_cal_receive_objects (priv->current_ecal, icalcomp, &error)) {
 			dialog = gnome_warning_dialog (error->message);
 			g_error_free (error);
 		} else {