looks good and seems to work as far as I can tell, so "ok to commit" Jeff On Wed, 2004-08-11 at 12:15 +0800, Not Zed wrote: > > here's another try and fixing the behaviour, revert the other one > first. > > it snatches any pending ops on the same password after the dialogue is > answered and broadcasts the same result to them all. > > it would be simpler to just look up the password in ep_ask_password > and return it directly, and change all of the re-asking logic in the > callers, but then it could get into loops and so on, so it wouldn't > work afterall. > > > On Tue, 2004-08-10 at 13:25 +0000, Not Zed wrote: > > > > this seems to be the only way to fix the password serialisation > > problem across all components. > > > > its more or less a movement of the mail's password stuff to e- > > password, including making it fully mt-safe, which greatly > > simplifies the mail's calls to it, and could probably simplify the > > async callbacks in other components too. > > > > it isn't entirely the same as what the mailer had though, since it > > now also guarantees execution order even from (recursive) calls from > > the gui thread, so i don't know if it hasn't added other problems. > > > > it will gaurantee you never get more than 1 password dialogue up at > > a time, requests areprocessed in the order they come in, etc etc. > > -- > > Michael Zucchi <notzed ximian com> > "born to die, live to work, it's > all downhill from here" > Novell's Evolution and Free > Software Developer -- Jeffrey Stedfast Evolution Hacker - Novell, Inc. fejj ximian com - www.novell.com
Attachment:
smime.p7s
Description: S/MIME cryptographic signature