Re: [evolution-patches] [calendar] patch for #60310



On Wed, 2004-08-11 at 01:40 -0400, JP Rosevear wrote:
> On Fri, 2004-08-06 at 17:18 +0200, Rodrigo Moya wrote:
> > On Sat, 2004-07-24 at 10:30 -0400, JP Rosevear wrote:
> > > On Sat, 2004-07-24 at 11:51 +0200, Rodrigo Moya wrote:
> > > > On Fri, 2004-07-23 at 15:44 -0400, JP Rosevear wrote:
> > > > > Why would the key be NULL in match_recurrence_sexp?
> > > > > 
> > > > not sure, since we can't add items to the hash table with a NULL key, or
> > > > can we? In any case, that's what seems to be the case.
> > > 
> > > Sounds like we are deleting items from the hash while in a foreach call
> > > or something similar.
> > > 
> > right, the attached patch might probably fix it. Can't confirm though
> > since I haven't been able to replicate the bug at all)
> 
> Does this render the free_recurrence iteration in free_object useless?
> 
no, because free_object is also called from other places. In the
remove_component case, when called, this function will just remove
nothing at all from the hash table, since they would have been removed
before.
-- 
Rodrigo Moya <rodrigo novell com>




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]