Re: [evolution-patches] all components, password serialisation patch

[Not Zed <notzed ximian com>]

On Tue, 2004-08-10 at 17:04 -0400, Jeffrey Stedfast wrote:
> discovered a bug while trying this out, crashed when I hit Send in my
> composer w/ SMIME Sign enabled because get_password() in mail-session.c
> tried to dereference a NULL service pointer.
>
> attached is the mail-session.c diff as it is after my patch to your
> patch.

Be nicer if you'd attached a diff between the two.

> arguably for the non-service case, we could do away with:
>
> if ((flags & CAMEL_SESSION_PASSWORD_STATIC) != 0)
> 	eflags = E_PASSWORDS_REMEMBER_NEVER;
> else
> 	eflags = E_PASSWORDS_REMEMBER_SESSION;
>
> and just do:
>
> eflags = E_PASSWORDS_REMEMBER_NEVER;
>
> since we can't actually remember non-service passwords anyway?

but that would change the behaviour.  we can remember non-service passwords for the session; thats the entire point of that code.

there are other issues anyway, since this doesn't actually entirely fix the multiple password prompt issue for groupwise.

-- 







Michael Zucchi <notzed ximian com>

"born to die, live to work, it's all downhill from here"

Novell's Evolution and Free Software Developer