Re: [evolution-patches] patch for re-adding 'Make this occurrence movable' menu item in calendar view

[Rodrigo Moya <rodrigo novell com>]

On Tue, 2004-08-10 at 08:19 -0400, JP Rosevear wrote:
> On Tue, 2004-08-10 at 12:19 +0200, Rodrigo Moya wrote:
> > On Mon, 2004-08-09 at 09:02 -0400, JP Rosevear wrote:
> > > On Mon, 2004-08-09 at 11:31 +0000, Rodrigo Moya wrote:
> > > > This menu item was removed by mistake some time ago. The string is
> > > > already in the .po files, so this doesnt break string freeze.
> > > 
> > > +       if (!e_cal_create_object (event->comp_data->client,
> > > e_cal_component_get_icalcomponent (new_comp), &new_uid, NULL))
> > > +               g_message ("e_day_view_on_unrecur_appointment(): Could
> > > not update the object!");
> > > +
> > > +       g_free (new_uid);
> > > 
> > > If there is an error, won't this potentially free new_uid when it points
> > > to garbage?
> > > 
> > right, updated patch attached. The other problem you mentioned (not
> > being able to remove all occurrences after making an occurrence movable)
> > is a bug on the file backend, so I'll send a separated patch for it.
> 
> Looks good.
> 
committed
-- 
Rodrigo Moya <rodrigo novell com>