Re: [evolution-patches] Fix for #58643 ( Calendar - GW backend) - deriving the gw item id from the itip message

[Rodrigo Moya <rodrigo novell com>]

On Mon, 2004-08-09 at 21:42 +0530, Harish Krishnaswamy wrote:
> hi,
> 
>  The patch adds code for correctly deriving the gw item id from the itip
> message by inserting the type markers for event and todo items.
> (macros GW_EVENT_TYPE_ID and GW_TODO_TYPE_ID). This enables us to
> assemble the id and handle accept/decline requests even if we have not 
> received an update from the soap interface.
> 

> @@ -715,6 +723,7 @@ e_gw_connection_send_appointment (EGwCon
>                         break;
>                 case ICAL_PARTSTAT_DECLINED:
>                         status = e_gw_connection_decline_request (cnc,
> item_id);
> +                       *remove = TRUE;
>                         break;
>                 case ICAL_PARTSTAT_TENTATIVE:
>                         status = e_gw_connection_accept_request (cnc,
> item_id, "Tentative");
> @@ -731,6 +740,7 @@ e_gw_connection_send_appointment (EGwCon
>  
>         case ICAL_METHOD_CANCEL:
>                 status = e_gw_connection_retract_request (cnc,
> item_id, NULL, FALSE, FALSE);
> +               *remove = TRUE;
>                 break;
>         default:
>                 status = E_GW_CONNECTION_STATUS_INVALID_OBJECT;
> 
it looks to me like 'remove' is not being set in all code paths, so I
guess it should at least be initialized to FALSE.

The rest looks ok
-- 
Rodrigo Moya <rodrigo novell com>