Re: [evolution-patches] Patch for bug #61673 (Tasks)

[Rodrigo Moya <rodrigo novell com>]

On Thu, 2004-08-05 at 16:11 +0530, Parthasarathi Susarla wrote:
> Hi all,
> Attached is the patch for bug # 616173. 
> There is a new error message string in calendar-errors.xml. The function
> save_component_dialog(present in the file
> calendar/gui/dialogs/save_comp.c) now takes 2 arguments instead of one.
> The second argument is a pointer to the ECalComponent structure, is used
> to determine the type of the component. An error message is displayed
> based on the component type.
> 

> @@ -24,13 +24,15 @@
>  #endif
>  
>  #include "widgets/misc/e-error.h"
> +#include <libecal/e-cal-component.h>
>  #include "save-comp.h"
> 
you should include e-cal-component.h in save-comp.h, since ECalComponent
is used there in the function prototype.

> +/* calendar:prompt-save-task secondary */
> +char *s = N_("You have made changes to this task, but not yet saved
> them.");
> +char *s = N_("Discard Changes");
> +char *s = N_("Save Changes");
>
is this needed (Discard/Save changes)? Those strings are already present
in the calendar-errors.xml|.h files.

Apart from that, it looks ok.
-- 
Rodrigo Moya <rodrigo novell com>