Re: [evolution-patches] gtkhtml, evolution crash when compose a html message




Just a comment, you shouldn't use g_return_if_fail if it is a possibly normal/valid condition.  Only if it is an error.  e.g. it might be ok in the code for that pointer to be NULL.

The code should still work and not crash without any of those assertions present.

On Wed, 2004-08-04 at 09:38 +0800, Eric Zhao wrote:
Hi,
  The attachment is a patch for bug #62223 .( 
http://bugs.ximian.com/show_bug.cgi?id=62223 ).
 
   Could you spend some time to give it a review? Thanks!

Regards,
Eric
_______________________________________________
evolution-patches mailing list
evolution-patches lists ximian com
http://lists.ximian.com/mailman/listinfo/evolution-patches
--
Michael Zucchi <notzed ximian com>
"born to die, live to work, it's all downhill from here"
Novell's Evolution and Free Software Developer


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]