Re: [evolution-patches] [Fwd: eds/calendar, crash import fix]



On Tue, 2004-08-03 at 13:39 +0200, Rodrigo Moya wrote:
> On Mon, 2004-08-02 at 14:45 +0800, Not Zed wrote:
> > 
> > i'm not very awake today
> > 
> 
> >         comp_uid = icalcomponent_get_uid (icalcomp);
> > +       if (comp_uid == NULL) {
> > +               char *uid = e_cal_component_gen_uid();
> >  
> > +               icalcomponent_set_uid(icalcomp, uid);
> > +               g_free(uid);
> > +               comp_uid = icalcomponent_get_uid (icalcomp);
> > +       }
> > +               
> I'm not sure, but we probably don't want to accept an icalcomponent
> without an UID. This is because the RFC says it's mandatory, so we
> probably should just return an InvalidObject error.

I don't see any problem creating it, we already do pedantic duplicate
uid checking.

-JP
-- 
JP Rosevear <jpr novell com>
Novell, Inc.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]