Re: [Fwd: Re: [evolution-patches] Patch for #ifdef'ed GtkFileChooser support]

[Hans Petter Jansson <hpj ximian com>]

On Thu, 2004-07-29 at 17:35 +0200, Carlos Garnacho wrote:
> On Wed, 2004-07-28 at 12:48 -0700, Chris Toshok wrote:

> > doh, mailed this just to Carlos.
> > email message attachment, "Forwarded message - Re: [evolution-patches]
> > Patch for #ifdef'ed GtkFileChooser support"

> > On Wed, 2004-07-28 at 12:48 -0700, Chris Toshok wrote:

> > > I'd rather see this patch use a feature check instead of a version
> > > check...
> > > 
> > > ala:
> > > 
> > > 	#if USE_GTKFILECHOOSER
> > > 
> > > instead of
> > > 
> > > 	#if GTK_CHECK_VERSION(2,4,0)

> You're right, this is already done in the patch I'm attaching. It also
> fixes a console warning I added in my code

Addressbook part looks ok to me.

--
Hans Petter