Re: [evolution-patches] Fix for 64-bit cleanliness in pkcs12 code
- From: Dan Winship <danw novell com>
- To: Rodney Dawes <dobey novell com>
- Cc: evolution-patches lists ximian com
- Subject: Re: [evolution-patches] Fix for 64-bit cleanliness in pkcs12 code
- Date: Mon, 02 Aug 2004 11:22:15 -0400
On Mon, 2004-08-02 at 10:46 -0400, Rodney Dawes wrote:
> This patch fixes the following warning in e-pkcs12.c:
>
> e-pkcs12.c: In function `prompt_for_password':
> e-pkcs12.c:243: warning: passing arg 2 of `memcpy' makes pointer from
> integer without a cast
>
> This can cause problems on 64-bit machines.
This is not a 64-bit problem. The problem is that the big-endian branch
of that code is completely wrong (and your patch doesn't fix it. Among
other things, note that uni isn't even initialized).
-- Dan
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]