Re: [evolution-patches] calendar patch for #57622

[Rodrigo Moya <rodrigo novell com>]

On Sun, 2004-08-01 at 19:48 -0400, JP Rosevear wrote:
> On Fri, 2004-07-30 at 13:58 +0200, Rodrigo Moya wrote:
> > On Thu, 2004-07-29 at 13:46 -0400, JP Rosevear wrote:
> > > On Thu, 2004-07-29 at 11:44 +0200, Rodrigo Moya wrote:
> > > > This fixes #57622. I don't like very much to remove all recurrences and
> > > > re-add them again in the objects_modified_cb, but trying to update every
> > > > individual recurrence (and removing the ones that don't apply anymore as
> > > > well as adding the new ones) might get the code too complicated for 2.0
> > > > I guess. With the attached patch, when you update a recurring
> > > > appointment, the recurrences disappear from the list view and show up
> > > > again at the end of the list, which might be confusing. Any suggestion?
> > > 
> > > The only problem I see is that "Delete this Occurrence" in the list view
> > > adds an exdate of 1/1/1970 instead of the correct date.
> > > 
> > right, we were using in that function the ECalViewEvent's start time,
> > which was only filled in in the day and week views. The attached patch
> > makes all views fill in the ECalModelComponent's instance_start, and
> > that is what is used.
> 
> Looks good.
> 
committed
-- 
Rodrigo Moya <rodrigo novell com>