On Mër , 2004-04-28 at 16:46 -0400, William Jon McCann wrote: > Hi, > > Here is a patch that will automatically "select" new sources. > > The idea is that if the user wants to subscribe to the calendar then > they consent to selecting the calendar and there is no need to require > the user to do this manually. > > Please let me know if this looks ok. > > Thanks, > Jon > > +static void select_source (ESource * source, icalcomponent_kind kind) > +{ This function addition doesn't follow the style of the rest of the code. > void e_webcal_query_user (const gchar * name, const gchar * desc, > const gchar * caluri, > - gboolean has_events, gboolean has_tasks) { > + gboolean has_events, gboolean has_tasks) > +{ This breaks code style on an existing function. Other than that, the patch looks ok. The style in evo-webcal is for the opening brace to be on the same line as the statement that opens it. -- dobey
Attachment:
signature.asc
Description: This is a digitally signed message part