Re: [evolution-patches] a patch on making an empty new event
- From: "alfred.peng" <alfred peng sun com>
- To: Rodrigo Moya <rodrigo ximian com>
- Cc: evolution-patches ximian com
- Subject: Re: [evolution-patches] a patch on making an empty new event
- Date: Fri, 30 Apr 2004 18:58:30 +0800
Dear Rodrigo,
I checked the code again. Actually Evolution itself doesn't use the
factory to create/edit a event. Only alarm use the factory to edit an
existing event. To use the factory, alarm have to use
bonobo_activation_activate to get the factory. Since the factory is the
Evolution itself, I think that's why evolutin
doesn't use the factory. It create the event editor directly instead.
If others want to create/edit a event, the factory is useful. So I
make some changes in the files "comp-editor-factory.c"
,"e-calendar-view.c" and "gnome-cal.c".
Rodrigo Moya wrote:
On Thu, 2004-04-29 at 19:59 +0800, alfred.peng wrote:
still doesnt look very well to me. I dont think there is a need for
having set_changed/set_is_new/whatever as new public functions. That is,
the comp-editor-factory knows when we are editing a new or an existing
component, so why not just do it privately in comp-editor-factory and
comp-editor?
cheers
_______________________________________________
Evolution-patches mailing list
Evolution-patches lists ximian com
http://lists.ximian.com/mailman/listinfo/evolution-patches
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]