Re: [evolution-patches] a patch on making a empty new appointment or task

[Alfred Peng <alfred peng sun com>]

Dear Rodrigo,

    Can you give me some advice on the patch? Or you just think this patch is unnecessary?

    Thanks

Best Regards
Alfred Peng

alfred.peng wrote:

Dear Rodrigo,

  I have a patch on making a empty new appointment or task. Would you please me to review it?

  Following is the detail.

  Scene A:
  Operation:
  1.open a existing appointment or task;
  2.clear all the contents of the appointment or task;
  3.save the appointment or task.
  Result:
      The empty appointment or task can be saved.

  Scene B:
  Operation:
  1.make a new appointment or task;
  2.make no change to the appointment or task
  3.save the appointment or task.
  Result:
      The empty appointment or task can't be saved.

  Compare A with B, we can find the difference: we *can't* make a empty appointment or task by making a new one.

  If the user makes a new appointment or task and clicks the "save" button, that means he wants to save the appointment or task even if he makes no change to it; if he want to cancel the edit, he'll click the "close" button.

  Do you think we should make some change to it? If so, I hope my patch can do it.

Best Regards

Alfred Peng

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
retrieving revision 1.2272
diff -u -r1.2272 ChangeLog
--- ChangeLog	22 Apr 2004 20:24:55 -0000	1.2272
+++ ChangeLog	24 Apr 2004 09:02:15 -0000
@@ -1,3 +1,25 @@
+2004-04-24  Alfred Peng <alfred peng sun com>
+
+	* gui/dialogs/comp-editor.c (comp_editor_init), 
+	(comp_editor_set_is_new): Add a new member variable "is_new"
+	and define a method to set the value.
+	(save_comp): When make a new empty appointment or task, and
+	click the "SAVE" button, save the appointment or the task
+	instead of ignoring the operation.
+	
+	* gui/dialogs/comp-editor.h: Add the method declaration.
+	
+	* gui/gnome-cal.c (gnome_calendar_new_task): Set tedit->is_new
+	to TRUE.
+	
+	* gui/comp-editor-factory.c (edit_new): Set editor->is_new to TRUE.
+
+	* gui/e-calendar-view.c (e_calendar_view_new_appointment_for):
+	Set editor->is_new to TRUE.
+
+	* gui/tasks-component.c (create_new_todo): Set editor->is_new to
+	TRUE.
+
 2004-04-22  Jeffrey Stedfast  
ximian-new.patch
Content-Type:
text/plain
Content-Encoding:
7bit