Re: [evolution-patches] Patch for 49702 (Find window lacks error messages)

[Jeffrey Stedfast <fejj ximian com>]

n/m, I looked at the wrong patch file before.

-		html_engine_search (d->html->engine, gtk_entry_get_text (GTK_ENTRY (d->entry)),
-				    GTK_TOGGLE_BUTTON (d->case_sensitive)->active,
-				    GTK_TOGGLE_BUTTON (d->backward)->active == 0, d->cd->regular);
-		break;

why did you remove the break?

+		if (!html_engine_search(d->html->engine, gtk_entry_get_text (GTK_ENTRY (d->entry)),
+		  GTK_TOGGLE_BUTTON (d->case_sensitive)->active,
+		    GTK_TOGGLE_BUTTON (d->backward)->active == 0, d->cd->regular)) {

please use the proper indenting here

+			e_notice (NULL, GTK_MESSAGE_INFO, _("Search string '%s' not found!"),

should we really be using an exclamation point? I'm not sure we should...

+			gtk_entry_get_text (GTK_ENTRY (d->entry)));
+		}
+

Jeff

On Fri, 2004-04-16 at 10:45 -0400, Jeffrey Stedfast wrote:
>     This patch contains a LOT more than it should based on what this is supposed to fix. Maybe you attached the wrong patch?
>     
>     Also, it would be nicer if you used Evolution to send these patches :-)
>     
>     Jeff
>     
>     On Fri, 2004-04-16 at 17:57 +0530, Pratik V. Parikh wrote: 
> > I propose a simple patch for this. It just shows an informational message
> > when the search string is not found.
> >
> > (There seems to be some problem with a few non ASCII characters in the
> > patch. Please ignore.)
> >
> > Patch attached.
> >