Re: [evolution-patches] e-d-s recompile when VERSION changes

[Chris Toshok <toshok ximian com>]

server-interface-check.o already has a dep on config.h (it #includes
it.)

Chris

On Mon, 2004-04-05 at 11:50 -0400, William Jon McCann wrote:
> Hi,
> 
> I have been building e-d-s using jhbuild with the "-a" option.
> 
> I noticed that every time I started evolution-1.5 it would kill the 
> "old" e-d-s even though e-d-s was up to date.
> 
> get_interfaceVersion was returning 0.0.7 even though pkg-config was 
> reporting 0.0.91.
> 
> Turns out that e-d-s/src/server-interface-check.o had not been 
> recompiled for about a month.
> 
> It should probably be recompiled whenever the VERSION changes.  VERSION 
> is stored in configure.in.  Configure writes the value to config.h.
> 
> One way to fix this is to add a dependency on config.h.  Here is a patch 
> to do that.
> 
> Does this look ok?  Or is there a better way to do this?
> 
> Thanks,
> Jon
> Plain text document attachment (e-d-s-build.patch)
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/evolution-data-server/ChangeLog,v
> retrieving revision 1.112
> diff -p -u -r1.112 ChangeLog
> --- ChangeLog	2 Apr 2004 16:28:16 -0000	1.112
> +++ ChangeLog	5 Apr 2004 15:36:45 -0000
> @@ -1,3 +1,8 @@
> +2004-04-05  William Jon McCann  <mccann jhu edu>
> +
> +	* src/Makefile.am ($(evolution_data_server_OBJECTS)): add a dependency
> +	on config.h so that a new VERSION will force a compilation.
> +
>  2004-04-02  JP Rosevear  <jpr ximian com>
>  
>  	* configure.in: bump version, libtool numbers
> Index: src/Makefile.am
> ===================================================================
> RCS file: /cvs/gnome/evolution-data-server/src/Makefile.am,v
> retrieving revision 1.15
> diff -p -u -r1.15 Makefile.am
> --- src/Makefile.am	19 Mar 2004 18:43:52 -0000	1.15
> +++ src/Makefile.am	5 Apr 2004 15:36:45 -0000
> @@ -49,6 +49,8 @@ evolution_data_server_SOURCES = \
>  	server-logging.h		\
>  	server.c
>  
> +$(evolution_data_server_OBJECTS): $(top_builddir)/config.h
> +
>  if ENABLE_LDAP
>  LDAP_BACKEND_LIB=$(top_builddir)/addressbook/backends/ldap/libebookbackendldap.la
>  else