Re: [evolution-patches] Patch for fixing free/busy hang issues in the eds Groupwise backend

[Harish Krishnaswamy <kharish novell com>]

The server always requires timezones to be UTC and fails to gork ISO
date-strings strings without the Z suffix. Hence, I modified the code
to use icaltime_from_time_t_with_zone and supplied the UTC timezones.

start and end times are time_t structures. are not they absolute in
nature, measured from 1970-01-01 00:00:00Z ? so there is no conversion
necessary, right ? Am i missing anything here ??

regards,
harish

On Mon, 2004-03-29 at 19:24, Rodrigo Moya wrote:
> On Mon, 2004-03-29 at 20:06 +0530, Harish Krishnaswamy wrote:
> 
> > hi,
> > 
> > the attached patch contains modifications in the FreeBusy requests sent
> > to the server. This complements the server side fixes and solves hang
> > issues in the event editor dialog.
> 
> 
> > @@ -396,14 +397,16 @@ start_freebusy_session (EGwConnection *c
> >          /*FIXME  the following code converts time_t to String
> > representation
> >           * through icaltime. Find if a direct conversion exists.  */ 
> >          /* Timezone in server is assumed to be UTC */
> > -        icaltime = icaltime_from_timet(start, FALSE );
> > -        start_date = icaltime_as_ical_string (icaltime);
> > -        
> > -        icaltime = icaltime_from_timet(end, FALSE);
> > -        end_date = icaltime_as_ical_string (icaltime);
> > +
> > +	utc = icaltimezone_get_utc_timezone ();
> > +	icaltime = icaltime_from_timet_with_zone (start, FALSE, utc);
> > +	start_date = icaltime_as_ical_string (icaltime);
> > +	
> > +	icaltime = icaltime_from_timet_with_zone (end, FALSE, utc);
> > +	end_date = icaltime_as_ical_string (icaltime);
> >         
> if using UTC, I guess you'll have to convert the start and end times
> from the local timezone to UTC.
> 
> Anyway, commit if this works, and fix the above problem, please.
> 
> cheers
>