Re: [evolution-patches] [shell]patch to fix focus issue of Account Assistant

[Yuedong Du <yuedong du sun com>]

Commited into Trunk,

York

Not Zed wrote:

> ahaah, ok, cool.  Must be a gtk whatever-version-it-is-this-week feature
> that we didn't have before.  Please commit.
>
> Michael
>
> On Tue, 2004-03-30 at 19:05 +0800, Eric Zhao wrote:
>  
>
> > Hi Zed,
> >   After we do change on the transport type when on the transport page,
> > the focus will be on the hostname edit widget, because this widget is
> > the next the widget. So the "grab_focus" operation is unnesseray.
> >
> > --
> > Regards,
> > Eric
> >
> >
> > On Mon, 2004-03-29 at 23:44 +0800, Not Zed wrote:
> >
> >    
> >
> > > So ... what happens when you DO change the transport type, WHEN on the
> > > transport page?
> > >
> > > On Mon, 2004-03-29 at 19:22 +0800, Eric Zhao wrote:
> > >      
> > >
> > > > Hi Zed,
> > > >   Sorry for missing the patch...
> > > >
> > > > --
> > > > Regard,
> > > > Eric
> > > >
> > > > On Mon, 2004-03-29 at 16:05 +0800, Not Zed wrote:
> > > >
> > > >        
> > > >
> > > > > Probably got ignored since the subject says shell, and its got nothing
> > > > > to do with the shell.
> > > > >
> > > > > Instead of commenting it out, just remove the line entirely.
> > > > >
> > > > > Still, what it does is supposed to work, without this line, what happens
> > > > > to the keyboard focus when you change the transport type?
> > > > >
> > > > >
> > > > > On Mon, 2004-03-29 at 15:44 +0800, Eric Zhao wrote:
> > > > >          
> > > > >
> > > > > > Hi,
> > > > > >   I posted this patch a month ago, but has no response. Would you
> > > > > > please spend little time reviewing it? Thanks!
> > > > > >
> > > > > > Atttached is a patch to fix the Tab navigation bug of Account
> > > > > > Assistant, which can be reproduced by the following steps:
> > > > > > (1) Invoke  your evo,
> > > > > > (2) Select Tool->Settings...
> > > > > > (3) Select mail Account->Add to open Account Assistant
> > > > > > After the Account Assistant is initiated, you can find that using Tab 
> > > > > > key to navigate around "Cancel", "Forward" buttons is impossible.
> > > > > >
> > > > > >   This bug is caused by the following code in
> > > > > > evolution/mail/mail-account-gui.c:618 
> > > > > >        gtk_widget_grab_focus (GTK_WIDGET (gui->transport.hostname));
> > > > > > This sentence transfers the focus to the hostname edit, but when
> > > > > > this function is called, the wizard is just on the start page, and
> > > > > > the hostname edit is unvisible, so Tab navigation failed.
> > > > > >
> > > > > >   Also I found that the code can't get the expected result -- set focus
> > > > > > to the host edit when the wizard is on the "Sending Email" page. So I
> > > > > > just commented this sentence.
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Eric Zhao <eric zhao sun com>
> > > > > >
> > > > > >            
> > > > > _______________________________________________
> > > > > Evolution-patches mailing list
> > > > > Evolution-patches lists ximian com
> > > > > http://lists.ximian.com/mailman/listinfo/evolution-patches
> > > > >          
> > > _______________________________________________
> > > Evolution-patches mailing list
> > > Evolution-patches lists ximian com
> > > http://lists.ximian.com/mailman/listinfo/evolution-patches
> > >      
> > _______________________________________________
> > Evolution-patches mailing list
> > Evolution-patches lists ximian com
> > http://lists.ximian.com/mailman/listinfo/evolution-patches
> >    
>
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches
>
>