Re: [Fwd: [evolution-patches] Fix for bug #48753:Pasting text from Evolution (email message) to Emacs obliterates the newlines]

[Antonio Xu <antonio xu sun com>]

Hello Larry

In the souce code of gtkhtml ,  I found clueflow cannot been selected due
to it cannot receive cursor. The object clueflow don't implement get_length
,and it just use the its parent's implemention. so everytime, When we paste
some text from gtkhtml, it need to judge whether this object can be selected,
so the object's length is a key value for judgement.  but clueflow's length
aways be zero.(In htmlobject, the funciton get_length just judge whether
the object can receive cursor. if so, it will retrun the length as 1), so
gtkhtml won't select clueflow due to it cannot receive cursor. That is the
real problem. I think maybe we should add the implementation of get_length
for clueflow.

Regards
Anto
Larry Ewing wrote:
> This patch will end up adding padding in places it shouldn't.  I'd much
> rather see some explaination of when and where the old logic was broken.
>
> --Larry
>
> On Thu, 2003-09-25 at 22:15, Antonio Xu wrote:
> >   I have to resent this patch again, I hope someone can review my patch.
> >
> > Thanks
> > Anto
> >
> > -------- Original Message --------
> > Subject: [evolution-patches] Fix for bug #48753:Pasting text from 
> > Evolution (email message) to Emacs obliterates the newlines
> > Date: Tue, 23 Sep 2003 18:25:31 +0800
> > From: Antonio Xu <antonio xu sun com>
> > To: evolution-patches ximian com
> >
> >
> >
> > Hello All,
> >
> > Please review my patch for bug #48753? This patch is apply to 1.4 branch.
> >
> > My patch will remove the judgement of clueflow's selected when we try to 
> > paste text from gtkhtml.
> >
> > Bug summary:
> >          Pasting text from Evolution (email message) to Emacs 
> > obliterates the newlines
> > Bug link:
> >          http://bugzilla.ximian.com/show_bug.cgi?id=48753
> >
> > Thanks
> > Antonio Xu
> >
> >
> >
> >
> > ______________________________________________________________________
> > Index: src/ChangeLog
> > ===================================================================
> > RCS file: /cvs/gnome/gtkhtml/src/ChangeLog,v
> > retrieving revision 1.1814.2.8
> > diff -u -p -r1.1814.2.8 ChangeLog
> > --- src/ChangeLog	15 Aug 2003 07:47:04 -0000	1.1814.2.8
> > +++ src/ChangeLog	23 Sep 2003 08:52:27 -0000
> > @@ -1,3 +1,8 @@
> > +2003-09-22  Antonio Xu  <antonio xu sun com>
> > +
> > +	* htmlclueflow.c (append_selection_string) : remove the judgement
> > +	of self->selected, fix buf #48753
> > +
> >  2003-08-15  Antonio Xu  <antonio xu sun com>
> >  
> >  	* htmlengine-edit-movement.c (html_engine_jump_at): add
> > Index: src/htmlclueflow.c
> > ===================================================================
> > RCS file: /cvs/gnome/gtkhtml/src/htmlclueflow.c,v
> > retrieving revision 1.288
> > diff -u -p -r1.288 htmlclueflow.c
> > --- src/htmlclueflow.c	20 May 2003 18:25:14 -0000	1.288
> > +++ src/htmlclueflow.c	23 Sep 2003 09:12:33 -0000
> > @@ -1786,10 +1786,8 @@ append_selection_string (HTMLObject *sel
> >  {
> >          (*HTML_OBJECT_CLASS (parent_class)->append_selection_string) (self, buffer);
> >  
> > -	if (self->selected) {
> > -		g_string_append_c (buffer, '\n');
> > -		plain_padding (HTML_CLUEFLOW (self), buffer, TRUE);
> > -	}
> > +	g_string_append_c (buffer, '\n');
> > +	plain_padding (HTML_CLUEFLOW (self), buffer, TRUE);
> >  }
> >  
> >  static gboolean
> >
> >