Re: [evolution-patches] Pl. discard the earlier patch: evolution/mail patch for 40917

[Not Zed <notzed ximian com>]

Hmm, i'm not sure about this fix.

 - it removes functionality, that of highlighting an incomplete field
 - it also changes the default gtkwidget behaviour, if its no longer calling grab_focus, do you need all the grab_focus signal handlers hooked onto?

I dunno - if you do the removal of trhe grab_focus calls, then you shouldn't need the grab_focus callbacks, but if you leave the focus calls in, then you should leave it in (and maybe change it?).

In my view, i would probably just remove the focus grabbing, and leave things otherwise alone - but this is a change in the behaviour, and needs to pass through UI (i.e. anna) first.

On Sun, 2003-09-28 at 01:57, Suresh Chandrasekharan wrote:
> Hi All,
> 	Sorry I sent the wrong one. This is the modified one.
> Thanks,
> Suresh