Re: [evolution-patches] patch for bug 48466

[Not Zed <notzed ximian com>]

Hi,

I'd be happier if you left the existing code structure in place - why exactly do you say it can remove an item more than once?

With you're changes you're actually changing the selection on the fly, and only by reversing the index list does it 'work' - although it is less transparent as to why it works.

I suggest you just change the last loop to be something like:
       
       for (p = attachment_list; p != NULL; p = p->next) {
                EMsgComposerAttachment *attachment = p->data;
                if (attachment->editor_gui != NULL) {
                      gtk_widget_destroy(glade_xml_get_widget(attachment->editor_gui, "dialog"));
                }    
               remove_attachment (bar, attachment);
        }

       

On Sun, 2003-09-14 at 15:49 +0800, Charles Zhang wrote:
> Hello, all.
>        In this patch, I fix bug 48466.
>        It's about the attatchment-bar in the composer.
>        I've modified most of the code of function "remove_selected" in 
> the file "e-msg-composer-attatchment-bar.c" under dir "composer", 
> because it is less efficient and dangerous. Following the origin code,  
> attatchment will be removed more than one times.
>        Please review it.
>
> Best Regards.
> Charles