Re: [evolution-patches] bug 48339, 48340, 48341, mailer, importer and contacts; druids cannot be closed by Esc key

[Anna Marie Dirks <anna ximian com>]

Hi Maxx, 

Thank you for your work on these patches. I am very happy to see
Evolution becoming more keyboard accessible. 

I appreciate that you have added confirmation messages for each of these
assistants; however, before these patches can be committed, the wording
of these confirmation messages should be changed. 

The most important information that a confirmation message needs to
convey is that the user will lose her work if she chooses to exit the
assistant using the ESC key. So, the messages that we show the user need
to make this clear.

Further, the HIG specifies that the button names used in a confirmation
message should be "Cancel", and an affirmative verb or verb phrase which
answers the question being asked in the message. So, in the case of
these assistants, the button names should be "Cancel", and "Quit
Assistant". (Because the question being asked is "Do you want to quit
the assistant".)

I know that this explanation is probably not very clear. For the full
text of the HIG's specification, please check the following link: 
http://developer.gnome.org/projects/gup/hig/1.0/windows.html#alert-button-order .

So, on to the text for the confirmation messages. For the Importer
Assistant, please use the following message: 

        If you quit the Evolution Importer Assistant now, all of the
        data that you have begun to import will be lost. You will need
        to run this assistant again if you wish to import the data. 
        
        Do you want to quit using the Assistant now?
        
        <Cancel> <Quit Assistant>

For the new mail account assistant, please use the following message: 

        If you quit the Evolution Account Assistant now, the account
        that you have begun to configure will be discarded. You will
        need to run this assistant again if you wish to create the
        account. 
        
        Do you want to quit using the Assistant now?
        
        <Cancel> <Quit Assistant>
        

For the ldap server assistant, please use the following message: 

        If you quit the Evolution LDAP Assistant now, the directory
        server that you have begun to add will be discarded. You will
        need to run this assistant again if you wish to add the
        directory server.
        
        Do you want to quit using the Assistant now?
        
        <Cancel> <Quit Assistant>

Does that makes sense? Again, the idea is to make sure that user has
been forewarned that she is going to lose her work. Please let me know
if you would like me to explain this matter further.

best,
Anna

Il ven, 2003-09-12 alle 17:05, Not Zed ha scritto:
> The mail part looks ok
> 
> On Fri, 2003-09-12 at 14:26 +0800, Maxx Cao wrote: 
> > Hi,
> > 
> > Please ignore my last mail. I've changed the mail title and resent this 
> > patch.
> > 
> > The bugs' summary are listed as follows:
> > 
> > 48339 <http://bugzilla.ximian.com/show_bug.cgi?id=48339>    Import 
> > wizard does not close on `ESC`
> > 48341 <http://bugzilla.ximian.com/show_bug.cgi?id=48341>    Add new mail 
> > account window does not close on Esc
> > 48340 <http://bugzilla.ximian.com/show_bug.cgi?id=48340>    Add/Edit 
> > directory servers windows do not close on Esc
> > 
> > 
> > These 3 bugs are almost the same. So I attach the patches together here.
> > They're quite simple. Please review, thanks!
-- 
Anna Marie Dirks <anna ximian com>