Re: [evolution-patches] Reverting patch for 46013 (focusable buttons in the composer UI)

[Jeffrey Stedfast <fejj ximian com>]

looks good.

On Fri, 2003-09-12 at 16:52, Ettore Perazzoli wrote:
> Hello,
> 
> On Thu, 2003-07-17 at 01:52, Yiming Cao wrote:
> > One-line patch for #46013, "Can't focus on to/cc button in composer".
> > 
> > The original author seems to UNSET this flag intentionally, but I can't
> > turn up the reason. I've tested it and didn't notice any side effect.
> > Can anybody give some ideas?
> 
> As discussed on evolution-hackers a couple days ago, I want to revert
> this patch before making the 1.4.5 tarball (hopefully today).
> 
> The reason why the to/cc/bcc buttons are not focusable is that this way
> you can use Tab to go through the to/cc/bcc fields directly.  With your
> patch applied you end up having to type Tab twice to go e.g. from To: to
> Cc:, which is annoying, and not what the users expect.
> 
> I think the correct way to fix the accessibility problem is to add
> accelerators; this way you can activate the buttons with the keyboard,
> but at the same time you have proper Tab navigation.  (Although this
> would break string freeze on the stable version, so it should probably
> only happen on HEAD.)
> 
> We might want to add a menu item for firing the destination address
> picker as well...
> 
> -- Ettore
> 
> ______________________________________________________________________
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/evolution/composer/ChangeLog,v
> retrieving revision 1.544.2.13
> diff -u -p -r1.544.2.13 ChangeLog
> --- ChangeLog	29 Aug 2003 05:57:25 -0000	1.544.2.13
> +++ ChangeLog	12 Sep 2003 20:41:00 -0000
> @@ -1,3 +1,9 @@
> +2003-09-12  Ettore Perazzoli  <ettore ximian com>
> +
> +	* e-msg-composer-hdrs.c (header_new_recipient): Make the entry
> +	non-focusable again.  The right fix for A11Y is to add
> +	accelerators.
> +
>  2003-08-22  Antonio Xu  <antonio xu sun com>
>  
>  	* e-msg-composer-attachment.c (): Connect response signal to
> Index: e-msg-composer-hdrs.c
> ===================================================================
> RCS file: /cvs/gnome/evolution/composer/e-msg-composer-hdrs.c,v
> retrieving revision 1.114.2.2
> diff -u -p -r1.114.2.2 e-msg-composer-hdrs.c
> --- e-msg-composer-hdrs.c	13 Aug 2003 17:22:09 -0000	1.114.2.2
> +++ e-msg-composer-hdrs.c	12 Sep 2003 20:41:00 -0000
> @@ -472,7 +472,7 @@ header_new_recipient (EMsgComposerHdrs *
>  	priv = hdrs->priv;
>  	
>  	ret.label = gtk_button_new_with_label (name);
> -
> +	GTK_OBJECT_UNSET_FLAGS (ret.label, GTK_CAN_FOCUS);
>  	g_signal_connect_data (ret.label, "clicked",
>  			       G_CALLBACK (address_button_clicked_cb),
>  			       e_msg_composer_hdrs_and_string_create (hdrs, name),
-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com